This repository was archived by the owner on May 12, 2021. It is now read-only.
v2: Open log fifo with RDWR instead of WRONLY#2608
Merged
grahamwhaley merged 1 commit intoApr 14, 2020
Conversation
The container log fifo is opened as `O_WRONLY` now. When the read side of fifo is closed temporarily such as restarting contaienrd, write to `tty.Stdout` will get an EPIPE error and finally cause `io.CopyBuffer` return. Then `ioCopy` closes the tty io and exits. Thus after containerd restarted, the log fifo can't be reopened. The container will be blocked forever after stdout/stderr buffer is full. Opening the log fifo with `RDWR` instead of `WRONLY` avoids the fifo returning EPIPE when the read side is closed, and keeps the fifo open until the reader reopening it. Fixes: kata-containers#2590 Signed-off-by: Li Yuxuan <liyuxuan04@baidu.com>
Contributor
Author
|
Hi @devimc the travis-ci seems happy here😆 Could you please restart the two failed cases as they have passed before? |
Contributor
Author
|
This PR makes #2591 ok as well, let's continue the discussion there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of #2591
Create a new PR to see if the travis-ci still stuck
Fixes: #2590
Signed-off-by: Li Yuxuan liyuxuan04@baidu.com