This repository was archived by the owner on May 12, 2021. It is now read-only.
stable-1.10 backports#2619
Merged
Merged
Conversation
The container log fifo is opened as `O_WRONLY` now. When the read side of fifo is closed temporarily such as restarting contaienrd, write to `tty.Stdout` will get an EPIPE error and finally cause `io.CopyBuffer` return. Then `ioCopy` closes the tty io and exits. Thus after containerd restarted, the log fifo can't be reopened. The container will be blocked forever after stdout/stderr buffer is full. Opening the log fifo with `RDWR` instead of `WRONLY` avoids the fifo returning EPIPE when the read side is closed, and keeps the fifo open until the reader reopening it. Fixes: kata-containers#2590 Signed-off-by: Li Yuxuan <liyuxuan04@baidu.com> (cherry picked from commit 8e0f891)
Instead, report an error and exit gracefully, as shown below: ``` dahmer fidencio # podman run -ti --runtime=/usr/bin/kata-runtime fedora sh Error: virtiofsd path (/usr/libexec/virtiofsd) does not exist: OCI runtime error ``` Fixes: kata-containers#2582 Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> (cherry picked from commit fd625b3)
amshinde
approved these changes
Apr 15, 2020
devimc
approved these changes
Apr 15, 2020
vfio devices hotplugged in the VM are expected to be handled by the kernel driver in the guest, hence the char vfio devices shouldn't appear in the container under /dev/vfio/. fixes kata-containers#2539 Signed-off-by: Julio Montes <julio.montes@intel.com> (cherry picked from commit 4d2574a)
Contributor
Author
|
/test |
Codecov Report
@@ Coverage Diff @@
## stable-1.10 #2619 +/- ##
===============================================
+ Coverage 48.97% 49.11% +0.13%
===============================================
Files 111 111
Lines 16021 16030 +9
===============================================
+ Hits 7847 7873 +26
+ Misses 7207 7185 -22
- Partials 967 972 +5 |
Contributor
Author
|
Seems that we will need to update to go 1.13.9 as we are hitting this issue: This failure happens when trying to run the containerd tests (including shimv2). |
GabyCT
pushed a commit
to GabyCT/tests-1
that referenced
this pull request
Apr 16, 2020
With golang updated to v1.13, we found golangci-lint build error on ARM CI. Taking advices here( filecoin-project/venus#3486 (comment)), we need to update golangci-lint to v1.18.0 to get Go 1.13 support. Fixes: kata-containers#2434 Depends-on: github.com/kata-containers/runtime#2619 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
|
Travis failed with the dreaded error... |
jodh-intel
approved these changes
Apr 16, 2020
Update golang to 1.13.9 in versions.yaml. In addition, add same golang version to `.travis.yml` and delete the call to `.ci/install_go.sh` as it started to cause problems in travis CI. Fixes: kata-containers#2592. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
GabyCT
pushed a commit
to GabyCT/tests-1
that referenced
this pull request
Apr 16, 2020
With golang updated to v1.13, we found golangci-lint build error on ARM CI. Taking advices here( filecoin-project/venus#3486 (comment)), we need to update golangci-lint to v1.18.0 to get Go 1.13 support. Fixes: kata-containers#2434 Depends-on: github.com/kata-containers/runtime#2619 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Contributor
Author
|
/test |
We currently use containerd v1.3.0, but this version has an issue when running the containerd/cri tests with go 1.13. This commit: 3a4acfbc99aa976849f51a8edd4af20ead51d8d7 from branch release/1.3 contains the fix to be able to run the tests with go 1.13. Fixes: kata-containers#2562. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com> (cherry picked from commit e62a8aa)
There is a typo 'emtpy' instead of 'empty' in a error message Fixes: kata-containers#2465 Signed-off-by: Liu Xiaodong <xiaodong.liu@intel.com> (cherry picked from commit 0f720e6)
Contributor
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits backported:
v2: Open log fifo with
RDWRinstead ofWRONLY… ffa090aqemu: Don't crash if virtiofsd path is non existent … cbfb3a4
virtcontainers: Don't create vfio devices in the guest … 11838d0