This repository was archived by the owner on May 12, 2021. It is now read-only.
Makefile: add missing dependencies to install targets#284
Merged
bergwolf merged 1 commit intoMay 3, 2018
Merged
Conversation
"make install" fails on a clean working directory: $ make install install: cannot stat ‘data/kata-collect-data.sh’: No such file or directory This happens because install and install-scripts do not depend on the runtime. Make doesn't know it needs to build the runtime before it can be installed. Add the missing dependencies to the install targets so that "make install" works on a clean working directory and rebuilds when source files have been modified. Note that SCRIPTS contains the generated kata-collect-data.sh script. That file needs to be generated before it can be installed, so make SCRIPTS a dependency of install-scripts. Fixes: kata-containers#283 Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
sboeuf
approved these changes
May 2, 2018
|
@stefanha thanks for the PR. I have restarted the fedora build, we got a glitch here. I'll merge when the CI turn green. |
Member
|
CI failed crio redis-server test: |
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 65.64% 65.64%
=======================================
Files 75 75
Lines 8008 8008
=======================================
Hits 5257 5257
Misses 2181 2181
Partials 570 570Continue to review full report at Codecov.
|
Member
|
lgtm |
mcastelino
added a commit
to mcastelino/runtime-1
that referenced
this pull request
Dec 15, 2018
Add firecracker swagger definition v2.0 retrieved from https://github.com/firecracker-microvm/firecracker-go-sdk/blob/master/client/swagger.yaml at 840c1e37f5f2bbcbff1fdbfcfcea09d0bf158977 This will be used to generate the client code. Fixes: kata-containers#284 Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
mcastelino
added a commit
to mcastelino/runtime-1
that referenced
this pull request
Dec 15, 2018
Add firecracker swagger definition v2.0 retrieved from https://github.com/firecracker-microvm/firecracker-go-sdk/blob/master/client/swagger.yaml at 840c1e37f5f2bbcbff1fdbfcfcea09d0bf158977 This will be used to generate the client code. Fixes: kata-containers#284 Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
grpc: Don't close the terminal on CloseStdin() call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"make install" fails on a clean working directory:
$ make install
install: cannot stat ‘data/kata-collect-data.sh’: No such file or directory
This happens because install and install-scripts do not depend on the
runtime. Make doesn't know it needs to build the runtime before it can
be installed.
Add the missing dependencies to the install targets so that "make
install" works on a clean working directory and rebuilds when source
files have been modified.
Note that SCRIPTS contains the generated kata-collect-data.sh script.
That file needs to be generated before it can be installed, so make
SCRIPTS a dependency of install-scripts.
Fixes: #283
Signed-off-by: Stefan Hajnoczi stefanha@redhat.com