runtime: Don' call bindUnmountContainerRootfs if container's rootfs u…

[keloyang]

buildContainerRootfs don't call bindMountContainerRootfs if container's rootfs use devicemapper
device in https://github.com/kata-containers/runtime/blob/master/virtcontainers/kata_agent.go#L1300,
so bindUnmountContainerRootfs should not be called if container's rootfs use devicemapper device
in https://github.com/kata-containers/runtime/blob/master/virtcontainers/container.go#L1123

Fixes: #2914

Signed-off-by: Shukui Yang keloyangsk@gmail.com

[cmaf]

/test-ubuntu

[fidencio]

lgtm!

[fidencio]

@bergwolf, do we have the same condition on the rust agent? If so, this PR must be forward-ported to the kata-containers/kata-containers branch.

For sure it also deserves a backport to the stable-1.11 branch as well.

[codecov]

Codecov Report

Merging #2915 into master will increase coverage by 0.23%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master    #2915      +/-   ##
==========================================
+ Coverage   51.44%   51.68%   +0.23%     
==========================================
  Files         118      118              
  Lines       17428    17440      +12     
==========================================
+ Hits         8966     9013      +47     
+ Misses       7379     7342      -37     
- Partials     1083     1085       +2     

[egernst]

Thanks for the change. I’m wondering if we should be augmenting our unit tests to exercise this. Any interest in helping with this @keloyang ?

[keloyang]

I'm happy to do this and I have change for this pr, PTAL, thanks. @egernst @fidencio

[devimc]

/test

[jodh-intel]

Thanks @keloyang.

Would you be able to forward-port this to Kata 2.0 too (https://github.com/kata-containers/kata-containers/tree/2.0-dev/src/runtime) ?

lgtm

[keloyang]

ping @egernst @jodh-intel @fidencio

[fidencio]

/retest

[cmaf]

@keloyang this is failing on 2 required checks ("jenkins-ci-ubuntu-18-04" and "jenkins-metrics-ubuntu-18-04") I'm seeing a 404 error instead of the results, so I'm retesting.

/test

[amshinde]

This check here should prevent bindUnmountContainerRootfs from being called. If it were being called, the bindUnmountContainerRootfs call would have returned an error which would have been propogated up the stack.
Are you seeing otherwise?

[keloyang]

@amshinde thanks for your review. I think we still need this change. bindUnmountContainerRootfs is called in several places ，there is no check in https://github.com/kata-containers/runtime/blob/master/virtcontainers/container.go#L1123.
in addition，call bindUnmountContainerRootfs don't always return error, see https://github.com/kata-containers/runtime/blob/master/virtcontainers/mount.go#L329.

[amshinde]

Ok fair enough.

[jodh-intel]

forward port PR: kata-containers/kata-containers#940