This repository was archived by the owner on May 12, 2021. It is now read-only.
qemu: clean up qmp channel#429
Merged
sboeuf merged 1 commit intokata-containers:masterfrom Jun 20, 2018
Merged
Conversation
Contributor
|
PSS Measurement: Memory inside container: |
|
lgtm The CI is failing due to lint issues. I don't yet understand why since:
|
|
Ugh - I've think I've just worked it out: kata-containers/tests#439. |
We only need one qmp channel and it is qemu internal detail thus sandbox.go does not need to be aware of it. Fixes: kata-containers#428 Signed-off-by: Peng Tao <bergwolf@gmail.com>
Contributor
|
PSS Measurement: Memory inside container: |
amshinde
approved these changes
Jun 20, 2018
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 63.77% 63.98% +0.21%
==========================================
Files 87 87
Lines 8823 8794 -29
==========================================
Hits 5627 5627
+ Misses 2592 2563 -29
Partials 604 604
Continue to review full report at Codecov.
|
sboeuf
approved these changes
Jun 20, 2018
lifupan
pushed a commit
to hyperhq/kata-runtime
that referenced
this pull request
Jun 22, 2018
qemu: clean up qmp channel
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
…c1-branch-bump # Kata Containers 1.5.0-rc1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only need one qmp channel and it is qemu internal detail thus
sandbox.go does not need to be aware of it.
This was part of #303 and but does not really relate to vm factory so I take it out.