This repository was archived by the owner on May 12, 2021. It is now read-only.
revert: "virtcontainers: support pre-add storage for frakti"#530
Merged
revert: "virtcontainers: support pre-add storage for frakti"#530
Conversation
|
lgtm |
sboeuf
force-pushed
the
revert-301-pre-addstorage-based-devmanager
branch
from
9cb8059 to
67a9d7d
Compare
This PR got merged while it had some issues with some shim processes being left behind after k8s testing. And because those issues were real issues introduced by this PR (not some random failures), now the master branch is broken and new pull requests cannot get the CI passing. That's the reason why this commit revert the changes introduced by this PR so that we can fix the master branch. Fixes #529 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
sboeuf
force-pushed
the
revert-301-pre-addstorage-based-devmanager
branch
from
67a9d7d to
927487c
Compare
sboeuf
changed the title
|
Build failed (third-party-check pipeline) integration testing with
|
Author
|
/recheck |
Author
Contributor
|
lgtm |
Contributor
|
PSS Measurement: Memory inside container: |
Author
|
@egernst please merge if you're fine with this. |
Member
|
Sorry for late response, I will investigate more and thank @sboeuf for fixing this! |
Author
|
@WeiZhang555 no problem, I hope you get this fixed quickly so that we can get your PR back ;) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR got merged while it had some issues with some shim processes
being left behind after k8s testing. And because those issues were
real issues introduced by this PR (not some random failures), now
the master branch is broken and new pull requests cannot get the
CI passing. That's the reason why this commit revert the changes
introduced by this PR so that we can fix the master branch.
Fixes #529
Signed-off-by: Sebastien Boeuf sebastien.boeuf@intel.com