Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Reseed guest random number generator after booting from vm factory#539

Merged
grahamwhaley merged 2 commits intokata-containers:masterfrom
bergwolf:crng
Aug 2, 2018
Merged

Reseed guest random number generator after booting from vm factory#539
grahamwhaley merged 2 commits intokata-containers:masterfrom
bergwolf:crng

Conversation

@bergwolf
Copy link
Member

@bergwolf bergwolf commented Jul 31, 2018

Because vm templating would share the initial kernel memory among guests, we need to reseed CRNG when new guests are created from template.

@katacontainersbot
Copy link
Contributor

PSS Measurement:
Qemu: 169819 KB
Proxy: 5791 KB
Shim: 8828 KB

Memory inside container:
Total Memory: 2043480 KB
Free Memory: 2003992 KB

@opendev-zuul
Copy link

opendev-zuul bot commented Jul 31, 2018

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@jodh-intel
Copy link

#524 and kata-containers/agent#312 are now merged so this just needs a rebase to resolve the conflict I think.

To include ReseedRandomDev grpc.

Full commits:
e398fd4 agent: add ReseedRandomDev rpc
8a51909 codecov: remove codecov.yml

Signed-off-by: Peng Tao <bergwolf@gmail.com>
@bergwolf
Copy link
Member Author

bergwolf commented Aug 2, 2018

@jodh-intel Yes, indeed. I have rebased the PR. ptal.

So that shared memory guests can still generate different
random numbers.

Fixes: kata-containers#538

Signed-off-by: Peng Tao <bergwolf@gmail.com>
@katacontainersbot
Copy link
Contributor

PSS Measurement:
Qemu: 167560 KB
Proxy: 4156 KB
Shim: 8981 KB

Memory inside container:
Total Memory: 2043480 KB
Free Memory: 2003712 KB

@opendev-zuul
Copy link

opendev-zuul bot commented Aug 2, 2018

Build succeeded (third-party-check pipeline).

@jodh-intel
Copy link

jodh-intel commented Aug 2, 2018

Thanks @bergwolf.

lgtm

Approved with PullApprove

@jodh-intel
Copy link

Ping @kata-containers/runtime .

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grahamwhaley grahamwhaley merged commit c871a90 into kata-containers:master Aug 2, 2018
@egernst egernst mentioned this pull request Aug 22, 2018
@sboeuf sboeuf added the feature New functionality label Sep 12, 2018
@bergwolf bergwolf deleted the crng branch September 13, 2018 03:26
zklei pushed a commit to zklei/runtime that referenced this pull request Jun 13, 2019
Fix a broken link in `TRACING.md`.

Fixes kata-containers#539.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants