virtcontainers: fix the issue of cleanup the vm's path#544
virtcontainers: fix the issue of cleanup the vm's path#544jodh-intel merged 1 commit intokata-containers:masterfrom
Conversation
To use the filepath.Join() instead of the simple string append method to form the file path, otherwise it will lose the "/" between the two parts. Fixes kata-containers#543. Signed-off-by: Fupan Li <lifupan@gmail.com>
|
Nice! lgtm |
|
PSS Measurement: Memory inside container: |
grahamwhaley
left a comment
grahamwhaley
left a comment
There was a problem hiding this comment.
Excellent cleanup. I'd spotted stuff being left in vm, but had not gotten around to adding the sanity check to the mega soak test and then reporting/tracking it down yet!
lgtm
|
I've kicked centos-7.4 CI to rebuild, as it looked like a network error. |
|
Build failed (third-party-check pipeline) integration testing with
|
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
=======================================
Coverage 66.54% 66.54%
=======================================
Files 94 94
Lines 9678 9678
=======================================
Hits 6440 6440
Misses 2546 2546
Partials 692 692 |
|
LGTM Good catch~ |
|
Ignoring openstack CI fail. All else is green, so merging... |
For now, update interface in agent will fail when hot-add nic to a running containers on arm64 as rescan pci bus will occur between uf and bf of shpc hotplug interrupt handling. Another problem is that the rootBusPath will be "/devices/platform/4010000000.pcie/pci0000:00" on arm64. To enable hot-add nic on arm64, rootBusPath should be changed here and shpc hotplug should be disabled in guest kernel. This patch just change rootBusPath. Fixes: kata-containers#544 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
7 participants
To use the filepath.Join() instead of the simple
string append method to form the file path, otherwise
it will lose the "/" between the two parts.
Fixes #543.
Signed-off-by: Fupan Li lifupan@gmail.com