This repository was archived by the owner on May 12, 2021. It is now read-only.
cli: support factory status command#546
Merged
amshinde merged 2 commits intokata-containers:masterfrom Aug 2, 2018
Merged
Conversation
It checks vm factory status and prints the result. Fixes: kata-containers#545 Signed-off-by: Peng Tao <bergwolf@gmail.com>
jodh-intel
reviewed
Aug 2, 2018
cli/factory.go
Outdated
| kataLog.WithField("factory", factoryConfig).Info("load vm factory") | ||
| f, err := vf.NewFactory(factoryConfig, true) | ||
| if err != nil { | ||
| fmt.Println("vm factory is off") |
There was a problem hiding this comment.
It might be worth changing this (and the other functions in this file) to be something like:
fmt.Fprintln(defaultOutputFile, "vm factory is off")
|
lgtm |
To follow the same rule as other commands. Signed-off-by: Peng Tao <bergwolf@gmail.com>
Contributor
|
PSS Measurement: Memory inside container: |
sboeuf
approved these changes
Aug 2, 2018
|
Build succeeded (third-party-check pipeline).
|
amshinde
approved these changes
Aug 2, 2018
Merged
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
Start a debug console if the `agent.debug_console` option is part of the kernel command line and a shell (bash or sh) is installed in the rootfs. The debug console is useful when the developer wants to debug the agent process or any other processes (even containers). The current way to do this is by modifying a systemd target + creating a new system unit, the problem with this approach is that it's not user-friendly and we depend on systemd, since it must be installed in the rootfs. fixes kata-containers#546 Signed-off-by: Julio Montes <julio.montes@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It checks vm factory status and prints the result.
Fixes: #545