This repository was archived by the owner on May 12, 2021. It is now read-only.
qemu: create vm directory before launching qemu#548
Merged
devimc merged 2 commits intokata-containers:masterfrom Aug 3, 2018
Merged
qemu: create vm directory before launching qemu#548devimc merged 2 commits intokata-containers:masterfrom
devimc merged 2 commits intokata-containers:masterfrom
Conversation
It looks to be left over due to merge conflicts. Signed-off-by: Peng Tao <bergwolf@gmail.com>
Right now we create it in `createsandbox` and it would create the vm dir unnecessarily for fetchsandbox() and it ends up leaving an empty vm dir behind even after DeleteSandbox. Fixes: kata-containers#547 Signed-off-by: Peng Tao <bergwolf@gmail.com>
Contributor
|
PSS Measurement: Memory inside container: |
|
lgtm |
|
Build succeeded (third-party-check pipeline).
|
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
+ Coverage 66.84% 66.87% +0.02%
==========================================
Files 85 85
Lines 9110 9107 -3
==========================================
Hits 6090 6090
+ Misses 2386 2383 -3
Partials 634 634 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we create it in
createsandboxand it wouldcreate the vm dir unnecessarily for fetchsandbox() and
it ends up leaving an empty vm dir behind even after
DeleteSandbox.
Fixes: #547