Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

virtcontainers: apply devices constraints #701

Closed
devimc wants to merge 1 commit into from
Closed

virtcontainers: apply devices constraints #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions virtcontainers/kata_agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,10 +666,9 @@ func constraintGRPCSpec(grpcSpec *grpc.Spec) {
// here: https://github.com/kata-containers/agent/issues/104
grpcSpec.Linux.Seccomp = nil

// By now only CPU constraints are supported
// By now only CPU, Memory and Devices constraints are supported
// Issue: https://github.com/kata-containers/runtime/issues/158
// Issue: https://github.com/kata-containers/runtime/issues/204
grpcSpec.Linux.Resources.Devices = nil
grpcSpec.Linux.Resources.Pids = nil
grpcSpec.Linux.Resources.BlockIO = nil
grpcSpec.Linux.Resources.HugepageLimits = nil
Expand Down
2 changes: 1 addition & 1 deletion virtcontainers/kata_agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ func TestConstraintGRPCSpec(t *testing.T) {
// check nil fields
assert.Nil(g.Hooks)
assert.Nil(g.Linux.Seccomp)
assert.Nil(g.Linux.Resources.Devices)
assert.NotNil(g.Linux.Resources.Devices)
assert.NotNil(g.Linux.Resources.Memory)
assert.Nil(g.Linux.Resources.Pids)
assert.Nil(g.Linux.Resources.BlockIO)
Expand Down