Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

vendor: fix govmm package#798

Merged
caoruidong merged 1 commit into
kata-containers:masterfrom
devimc:topic/depEnsure
Sep 29, 2018
Merged

vendor: fix govmm package#798
caoruidong merged 1 commit into
kata-containers:masterfrom
devimc:topic/depEnsure

Conversation

@devimc
Copy link
Copy Markdown

@devimc devimc commented Sep 28, 2018

Last time govmm was updated it was not vendored correctly

Fixes #797

Signed-off-by: Julio Montes julio.montes@intel.com

Last time govmm was updated it was not vendored correctly

Fixes kata-containers#797

Signed-off-by: Julio Montes <julio.montes@intel.com>
@jodh-intel
Copy link
Copy Markdown

What was the problem with the previous re-vendor?

@devimc
Copy link
Copy Markdown
Author

devimc commented Sep 28, 2018

@jodh-intel I think so, if you run dep ensure on master you'll see that govmm is modified but Gopkg.toml not

@jshachm
Copy link
Copy Markdown
Member

jshachm commented Sep 29, 2018

LGTM

Approved with PullApprove

@jshachm
Copy link
Copy Markdown
Member

jshachm commented Sep 29, 2018

/test

@katacontainersbot
Copy link
Copy Markdown
Contributor

PSS Measurement:
Qemu: 172269 KB
Proxy: 4174 KB
Shim: 8766 KB

Memory inside container:
Total Memory: 2043448 KB
Free Memory: 2005960 KB

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 29, 2018

Codecov Report

Merging #798 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #798   +/-   ##
=======================================
  Coverage   65.32%   65.32%           
=======================================
  Files          87       87           
  Lines       10619    10619           
=======================================
  Hits         6937     6937           
  Misses       2985     2985           
  Partials      697      697

@caoruidong caoruidong merged commit 9bc5828 into kata-containers:master Sep 29, 2018
@devimc devimc deleted the topic/depEnsure branch April 8, 2019 14:51
egernst pushed a commit to egernst/runtime that referenced this pull request Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants