Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

gocache: clean GOCACHE on AArch64#1366

Merged
chavafg merged 1 commit into
kata-containers:masterfrom
Pennyzct:clean_up_3_28
Mar 29, 2019
Merged

gocache: clean GOCACHE on AArch64#1366
chavafg merged 1 commit into
kata-containers:masterfrom
Pennyzct:clean_up_3_28

Conversation

@Pennyzct
Copy link
Copy Markdown
Contributor

Go command caches build outputs under $GOCACHE, The default location for cache data is a subdirectory named go-build/ in the standard user cache directory, like $XDG_CACHE_HOME in linux.
Since some CI, including ARM CI, is running on bare metal. We need to clean GOCACHE before each run.

Fixes: #1365

Signed-off-by: Penny Zheng penny.zheng@arm.com

@chavafg
Copy link
Copy Markdown
Contributor

chavafg commented Mar 28, 2019

/test

Comment thread .ci/lib.sh Outdated
@Pennyzct
Copy link
Copy Markdown
Contributor Author

Pennyzct commented Mar 29, 2019

Hi~ @chavafg @grahamwhaley @jodh-intel For jenkins-ci-opensuse-15 failure ERROR: Error cloning remote repo 'origin', i get a similar one in my another pr runtime/#1433, looks like a pattern, you may want to have a look. ;)

Go command caches build outputs under $GOCACHE, The default location
for cache data is a subdirectory named 'go-build' in the
standard user cache directory, like $XDG_CACHE_HOME in linux.
Since some CI, including ARM CI, is running on bare metal. We need
to clean GOCACHE before each run.

Fixes: kata-containers#1365

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
@Pennyzct
Copy link
Copy Markdown
Contributor Author

/test

@grahamwhaley
Copy link
Copy Markdown
Contributor

Hi @Pennyzct - I think the opensuse clone issue is a known problem right now - I think we can ignore that on this PR.

Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
nice catch. I guess you saw it cause some real issue - but cleaning up after ourselves is just good practice anyway!

@grahamwhaley
Copy link
Copy Markdown
Contributor

We have a few CI fails, but, this change should only affect bare metal machines, which means pretty much ARM, IBM and the metrics. The only one of those CIs to fail is the metrics, and that was happy with this code change (it failed as we need to adjust the metrics bounds check due to recent other code changes).

02:41:51 OK
02:41:51 INFO: Clean GOCACHE
02:41:51 ~/workspace/workspace/kata-metrics-tests-ubuntu-16-04-PR/go/src/github.com/kata-containers/tests ~/workspace/workspace/kata-metrics-tests-ubuntu-16-04-PR/go/src/github.com/kata-containers/tests

So, I'm happy this code change is good - if somebody else agrees, let's merge it.

@chavafg
Copy link
Copy Markdown
Contributor

chavafg commented Mar 29, 2019

Hi @Pennyzct, yes, we are having problems with the opensuse job, we can ignore it. Restarted the ubuntu and fedora job which failed on the shimv2 tests. Once those pass, we can merge.

@chavafg chavafg merged commit fa6c631 into kata-containers:master Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants