gocache: clean GOCACHE on AArch64#1366
Conversation
|
/test |
|
Hi~ @chavafg @grahamwhaley @jodh-intel For |
Go command caches build outputs under $GOCACHE, The default location for cache data is a subdirectory named 'go-build' in the standard user cache directory, like $XDG_CACHE_HOME in linux. Since some CI, including ARM CI, is running on bare metal. We need to clean GOCACHE before each run. Fixes: kata-containers#1365 Signed-off-by: Penny Zheng <penny.zheng@arm.com>
|
/test |
|
Hi @Pennyzct - I think the opensuse clone issue is a known problem right now - I think we can ignore that on this PR. |
grahamwhaley
left a comment
There was a problem hiding this comment.
lgtm
nice catch. I guess you saw it cause some real issue - but cleaning up after ourselves is just good practice anyway!
|
We have a few CI fails, but, this change should only affect bare metal machines, which means pretty much ARM, IBM and the metrics. The only one of those CIs to fail is the metrics, and that was happy with this code change (it failed as we need to adjust the metrics bounds check due to recent other code changes). So, I'm happy this code change is good - if somebody else agrees, let's merge it. |
|
Hi @Pennyzct, yes, we are having problems with the opensuse job, we can ignore it. Restarted the ubuntu and fedora job which failed on the shimv2 tests. Once those pass, we can merge. |
Go command caches build outputs under
$GOCACHE, The default location for cache data is a subdirectory namedgo-build/in the standard user cache directory, like$XDG_CACHE_HOMEin linux.Since some CI, including ARM CI, is running on bare metal. We need to clean
GOCACHEbefore each run.Fixes: #1365
Signed-off-by: Penny Zheng penny.zheng@arm.com