Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

depends-on: search for the tag only on the commit body#1437

Merged
chavafg merged 1 commit into
kata-containers:masterfrom
chavafg:topic/fix-depends-on
Apr 9, 2019
Merged

depends-on: search for the tag only on the commit body#1437
chavafg merged 1 commit into
kata-containers:masterfrom
chavafg:topic/fix-depends-on

Conversation

@chavafg
Copy link
Copy Markdown
Contributor

@chavafg chavafg commented Apr 9, 2019

Insted of getting the log with the subject + body of the
commit, only use the body to process the depends-on tag.

Fixes: #1436.

Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com

Insted of getting the log with the subject + body of the
commit, only use the body to process the depends-on tag.

Fixes: kata-containers#1436.

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
Copy link
Copy Markdown
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jcvenegas
Copy link
Copy Markdown
Member

/test

Copy link
Copy Markdown
Member

@jcvenegas jcvenegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually will block a bit more this ,

I see the range is master.. this should be "KATA_TARGET_BRANCH" or any name we use to export the branch to test.
branch=${OUR_TARGET_BRANCH:-master} would be better

@chavafg
Copy link
Copy Markdown
Contributor Author

chavafg commented Apr 9, 2019

@jcvenegas, I am not sure how to use stable branches here, as it returns an error.
E.g. from your change on #1434

$ git log --format=%b stable-1.5..
fatal: ambiguous argument 'stable-1.5..': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

but using master as reference work:

$ git log --format=%b master..
Clean the vm_template dir before test executes.

Fixes: #1363

Signed-off-by: Hui Zhu <teawater@hyper.sh>

Also, I would like to get this merged to unblock #1433 and we can continue discussing your concern on another issue, wdyt?

@chavafg chavafg merged commit 6f5c077 into kata-containers:master Apr 9, 2019
@chavafg chavafg deleted the topic/fix-depends-on branch July 17, 2019 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants