This repository was archived by the owner on Jun 28, 2024. It is now read-only.
depends-on: search for the tag only on the commit body#1437
Merged
Conversation
Insted of getting the log with the subject + body of the commit, only use the body to process the depends-on tag. Fixes: kata-containers#1436. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
jcvenegas
approved these changes
Apr 9, 2019
Member
|
/test |
jcvenegas
suggested changes
Apr 9, 2019
Member
jcvenegas
left a comment
There was a problem hiding this comment.
Actually will block a bit more this ,
I see the range is master.. this should be "KATA_TARGET_BRANCH" or any name we use to export the branch to test.
branch=${OUR_TARGET_BRANCH:-master} would be better
Contributor
Author
|
@jcvenegas, I am not sure how to use stable branches here, as it returns an error. but using master as reference work: Also, I would like to get this merged to unblock #1433 and we can continue discussing your concern on another issue, wdyt? |
jcvenegas
approved these changes
Apr 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insted of getting the log with the subject + body of the
commit, only use the body to process the depends-on tag.
Fixes: #1436.
Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com