This repository was archived by the owner on Jun 28, 2024. It is now read-only.
CI: Add explicit static check script vendor test#1508
Merged
Conversation
added 2 commits
April 29, 2019 08:59
Modify the `check_vendor()` function in the static check script. Rather than exiting the function as early as possible, change the logic to allow follow on future checks to be added. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Update the `check_vendor()` function in the static check script to run our current vendoring tool (`dep`) in check mode. This will ensure our vendoring does not get silently broken [1]. Fixes kata-containers#1506. [1] - See for example kata-containers/runtime#1442. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Author
|
/test |
grahamwhaley
approved these changes
Apr 29, 2019
Contributor
grahamwhaley
left a comment
grahamwhaley
left a comment
There was a problem hiding this comment.
heh, nice.
be fun to see if it passes right now... for all the repos...
Contributor
|
Odd metrics CI fail - will respin |
Author
|
@grahamwhaley - ftr, I have tested all repos locally and it appears fine, but only a real run (on each repo) will give us the full details of course... |
devimc
approved these changes
Apr 29, 2019
|
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
check_vendor()function in the static check script to run our current vendoring tool (dep) in check mode. This will ensure our vendoring does not get silently broken [1].Fixes #1506.
[1] - See for example kata-containers/runtime#1442.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com