Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

[DNM] clh: Add a ci job for crio tests#2621

Closed
likebreath wants to merge 3 commits into
kata-containers:masterfrom
likebreath:add_ci_job_k8s_crio
Closed

[DNM] clh: Add a ci job for crio tests#2621
likebreath wants to merge 3 commits into
kata-containers:masterfrom
likebreath:add_ci_job_k8s_crio

Conversation

@likebreath
Copy link
Copy Markdown
Contributor

@likebreath likebreath commented Jun 8, 2020 •
edited
Loading

This patch extends the existing scripts to cover a new Jenkins job on
testing k8s with crio for cloud-hypervisor.

Fixes: #2546

Depends-on: github.com/kata-containers/runtime#2833

@likebreath likebreath changed the title Add ci job k8s crio [DNM] Add ci job k8s crio Jun 8, 2020
@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jun 8, 2020

/test-clh

@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jun 8, 2020

/test-clh-crio

2 similar comments
@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jun 9, 2020

/test-clh-crio

@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jun 9, 2020

/test-clh-crio

@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jun 9, 2020

/test-clh-k8s-containerd

@jcvenegas
Copy link
Copy Markdown
Member

jcvenegas commented Jun 9, 2020

I see it is passing :D

@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jun 9, 2020

/test-clh-crio

@likebreath likebreath force-pushed the add_ci_job_k8s_crio branch 2 times, most recently from c995101 to 6901b34 Compare June 9, 2020 23:18
@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jun 9, 2020

/test-clh-crio

@likebreath likebreath force-pushed the add_ci_job_k8s_crio branch from 6901b34 to 7735537 Compare June 23, 2020 18:25
@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jun 23, 2020

/test-clh-crio

@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jun 23, 2020

/test-clh-k8s-containerd

@likebreath likebreath changed the title [DNM] Add ci job k8s crio [DNM] chl: Add a ci job for crio tests Jun 29, 2020
@likebreath likebreath changed the title [DNM] chl: Add a ci job for crio tests [DNM] clh: Add a ci job for crio tests Jun 29, 2020
@likebreath likebreath force-pushed the add_ci_job_k8s_crio branch from 7735537 to 8a1fa05 Compare July 8, 2020 00:39
@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jul 8, 2020

/test-clh-crio

@likebreath likebreath force-pushed the add_ci_job_k8s_crio branch from 8a1fa05 to 1b2152f Compare July 8, 2020 01:14
@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jul 8, 2020

/test-clh-crio

@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jul 8, 2020

/test-fc

@likebreath likebreath force-pushed the add_ci_job_k8s_crio branch from 1b2152f to 6897c77 Compare July 8, 2020 05:05
@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jul 8, 2020

/test-fc

@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jul 8, 2020

/test-clh-crio

@likebreath likebreath force-pushed the add_ci_job_k8s_crio branch from 6897c77 to 956394b Compare July 8, 2020 05:58
@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jul 8, 2020

/test-clh-crio

@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jul 8, 2020

/test-fc

@likebreath likebreath mentioned this pull request Jul 16, 2020
Closed
@likebreath likebreath force-pushed the add_ci_job_k8s_crio branch 2 times, most recently from 5ca7be7 to 7e63afb Compare July 16, 2020 02:57
@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jul 16, 2020

/test-clh-crio

1 similar comment
@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jul 16, 2020

/test-clh-crio

@likebreath likebreath force-pushed the add_ci_job_k8s_crio branch from 5efed90 to 0307f17 Compare July 16, 2020 05:14
@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jul 16, 2020

/test-clh-crio

@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jul 16, 2020

By enabling the block device unplug (kata-containers/runtime#2833), the cri-o integration tests are now passing quite many tests (at least the first 22 tests as shown here).

The failing test is test 23: privileged ctr device add, which is skipped for firecracker w/ kata for now. Also, I re-ran the CI few times and did see few unstable tests, especially test 18 ctr list label filtering (test 5 additional devices support failed once). I will take a closer look into those failings later.

@jcvenegas @sboeuf @chavafg

@sboeuf
Copy link
Copy Markdown

sboeuf commented Jul 16, 2020 •
edited
Loading

@likebreath

By enabling the block device unplug (kata-containers/runtime#2833), the cri-o integration tests are now passing quite many tests (at least the first 22 tests as shown here).

Nice! I see you made some interesting progress on this issue. Basically, the CRI-O tests don't really match the standard usage of Cloud-Hypervisor with Kata Containers since most of the time virtio-fs is involved for adding and removing a container's rootfs.
So maybe the first question is to ask ourselves if we want to keep the CRI-O test using devmapper as the storage driver, or if instead, and specifically to Cloud-Hypervisor, we want to switch to overlay FS so that virtio-fs is being used?
That being said, I think this CRI-O testing using devmapper as the storage driver is interesting as it triggers some bugs that couldn't be caught through other tests, so I'd be in favor of keeping it the way it is.

The failing test is test 23: privileged ctr device add, which is skipped for firecracker w/ kata for now. Also, I re-ran the CI few times and did see few unstable tests, especially test 18 ctr list label filtering (test 5 additional devices support failed once). I will take a closer look into those failings later.

I would try to understand what's going on with the test privileged ctr device add as we really want to be on par with QEMU (if possible). About the sporadic failures, keep that for later, as it might be time consuming (if hard to reproduce).

/cc @sameo

@likebreath likebreath force-pushed the add_ci_job_k8s_crio branch from 0307f17 to bff03dc Compare July 28, 2020 02:34
@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Jul 28, 2020

/test-clh-crio

@likebreath likebreath force-pushed the add_ci_job_k8s_crio branch from bff03dc to 204cd66 Compare August 14, 2020 21:06
@likebreath
Copy link
Copy Markdown
Contributor Author

likebreath commented Aug 14, 2020

/test-clh-crio

@likebreath
ci: Run k8s tests with containerd in a dedicated Jenkins job for clh
fa04f8d 
This patch separates the k8s tests using containerd from the main CI job
of cloud-hypervisor ("CLOUD-HYPERVISOR") into a dedicated Jenkins
job. It provides better modularity and maintainability, especially for
adding a new Jenkins job to run k8s tests with cri-o.

Signed-off-by: Bo Chen <chen.bo@intel.com>
@likebreath
ci: Add k8s tests using crio for cloud-hypervisor
0f4cd05 
This patch extends the existing scripts to cover a new Jenkins job on
testing k8s with crio for cloud-hypervisor.

Fixes: kata-containers#2546

Signed-off-by: Bo Chen <chen.bo@intel.com>
@likebreath
cri-o: Skip one test for clh
204cd66 
Skipped test: "privileged ctr device add"

Signed-off-by: Bo Chen <chen.bo@intel.com>
@c3d c3d added the do-not-merge PR has problems or depends on another label Oct 6, 2020
@c3d
Copy link
Copy Markdown
Member

c3d commented Oct 6, 2020

Adding dnm label (as opposed to in-title)

@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Jan 5, 2021

@likebreath - is this PR still needed? If so, please can you rebase as it's conflicted.

@likebreath likebreath closed this Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge PR has problems or depends on another

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clh: Enable crio testing

5 participants

@likebreath @jcvenegas @sboeuf @c3d @jodh-intel