This repository was archived by the owner on Jun 28, 2024. It is now read-only.
metrics: history update query paths#2667
Merged
jcvenegas merged 1 commit intoJun 23, 2020
Merged
Conversation
jcvenegas
added a commit
to jcvenegas/runtime
that referenced
this pull request
Jun 22, 2020
Useful when ksm is enabled. Fixes: #1 Depends-on: github.com/kata-containers/tests#2667 Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
Member
Author
|
/test-clh |
jodh-intel
approved these changes
Jun 23, 2020
| local result_url="${build_url}/${test}.json" | ||
| echo " $result_url" | ||
| # Can fail if the build failed to generate any results | ||
| if ! curl --output /dev/null --silent --head --fail "$result_url"; then |
There was a problem hiding this comment.
Add -L for parity with the final curl below?
devimc
approved these changes
Jun 23, 2020
Recently metrics artifacts started to be collected with teardown script, urls to download now are pointing to a new path. This patch updates the paths to query if find a valid json file will download it. Fixes: kata-containers#2666 Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
jcvenegas
force-pushed
the
update-artifact-history
branch
from
90f83c2 to
7e2a2af
Compare
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently metrics artifacts started to be collected
with teardown script, urls to download now are
pointing to a new path.
This patch updates the paths to query if
find a valid json file will download it.
Fixes: #2666
Signed-off-by: Jose Carlos Venegas Munoz jose.carlos.venegas.munoz@intel.com