This repository was archived by the owner on Jun 28, 2024. It is now read-only.
metrics: clh: Loose the check on the minVal of memory footprint#2809
Merged
GabyCT merged 1 commit intoAug 25, 2020
Merged
Conversation
Contributor
Author
|
/test-clh-metrics |
Contributor
Author
|
/test-ubuntu |
likebreath
force-pushed
the
clh_metrics_loose_memory_minval
branch
from
e7b3bd1 to
d25d8bc
Compare
We observed the CLH metrics CI can fail with decreased memory footprint (compared with the reference value). As we are more concerned about the increased memory footprint, this patch loosed the checks on the minVal by increasing the `minpercent` from `5.0` to `25.0`. Fixes: kata-containers#2808 Signed-off-by: Bo Chen <chen.bo@intel.com>
Contributor
Author
|
The Travis CI is failing on the |
amshinde
approved these changes
Aug 25, 2020
Member
|
This seems to be the actual error:remote: I am going to restart it one last time to see if it fails. |
Contributor
Author
|
/test-clh-metrics |
jodh-intel
approved these changes
Aug 25, 2020
jodh-intel
left a comment
jodh-intel
left a comment
There was a problem hiding this comment.
lgtm
Does it need porting to the 2.0 tests branch?
GabyCT
approved these changes
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We observed the CLH metrics CI can fail with decreased memory
footprint (compared with the reference value). As we are more concerned
about the increased memory footprint, this patch loosed the checks on
the minVal by increasing the
minpercentfrom5.0to25.0.Fixes: #2808
Signed-off-by: Bo Chen chen.bo@intel.com