This repository was archived by the owner on Jun 28, 2024. It is now read-only.
CI: fix static-checks for stable branches#652
Merged
chavafg merged 2 commits intokata-containers:stable-1.1from Aug 27, 2018
Merged
CI: fix static-checks for stable branches#652chavafg merged 2 commits intokata-containers:stable-1.1from
chavafg merged 2 commits intokata-containers:stable-1.1from
Conversation
Contributor
|
lgtm |
Contributor
|
lgtm |
This fix will allow static-checks.sh tool to compare the file diffs with the correct branch instead of doing it with master. Fixes kata-containers#651. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
nitkon
reviewed
Aug 27, 2018
.ci/jenkins_job_build.sh
Outdated
| [ -z "$pr_number" ] && master_branch="true" | ||
| .ci/static-checks.sh "$kata_repo" "$master_branch" | ||
| specific_branch="" | ||
| # If not a PR, we are testing an stable or master branch. |
Contributor
There was a problem hiding this comment.
Nit: typo "testing on stable or master branch"
.ci/static-checks.sh
Outdated
| repo-name : GitHub URL of repo to check in form "github.com/user/repo". | ||
| true : Specify as "true" if testing the 'master' branch, else assume a | ||
| PR branch. | ||
| true : Specify as "true" if testing an specific branch (stable or master), |
Contributor
There was a problem hiding this comment.
Nit: typo "if testing a specific branch (stable or master),"
chavafg
force-pushed
the
topic/url-fix-1.1
branch
from
63e61cc to
b3f4e05
Compare
Contributor
Author
|
@nitkon fixed typos :) |
Fix the way that we are doing the swarm init when we have multiple interfaces with different addresses Fixes kata-containers#483 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix will allow static-checks.sh tool to compare
the file diffs with the correct branch instead of
doing it with master.
Fixes #651.
Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com