Fix cache corruption due to recorder reuse#1146
Merged
kataras merged 1 commit intokataras:masterfrom Dec 2, 2018
hendrikhofstadt:patch-1
Merged
Fix cache corruption due to recorder reuse#1146kataras merged 1 commit intokataras:masterfrom hendrikhofstadt:patch-1
kataras merged 1 commit intokataras:masterfrom
hendrikhofstadt:patch-1
Conversation
|
|
Owner
|
Thanks @SLAMPER ! |
github-actions Bot
pushed a commit
to goproxies/github.com-kataras-iris
that referenced
this pull request
Jul 27, 2020
Fix cache corruption due to recorder reuse Former-commit-id: e010b13230f93e0dab208bc1558aca094efc1667
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the body of a cache entry is set to the
chunksof a request recorder.However recorders are reused. If now a recorder is being reused and a cache entry points to a slice of the same array that is used to record the new request the cache entry is overwritten thereby corrupting the cache.
We need to copy the body to avoid this and make the cache entry immutable.