Added container scope for yetiforce 4.4 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
We could set the default for the container attribute of the client to "restapi" in the constructor and i believe this would be a drop in replacement for users who have upgraded. It was hard for me to tell if the previous implementation was portal or restapi but restapi is free and seems to implement the previous api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for yetiforce 4.4 by implementing the "container" scope in api requests. I chose to add a client initialization attribute, I assumed this would be ideal since yetiforce has added several external app integration methods, portal, restapi, etc. Each of these needs unique tokens so you would need new clients for each type anyway. Hope this helps!