Skip to content

don't restrict species search to ncbi#100

Merged
1 commit merged intodevelopfrom
DATAUP-701-query-testing
Feb 25, 2022
Merged

don't restrict species search to ncbi#100
1 commit merged intodevelopfrom
DATAUP-701-query-testing

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 24, 2022

  • I updated the README.md docs to reflect this change.

For changes to the codebase:

  • I have written tests to cover this change.
  • This is not a breaking API change OR
  • This is a breaking API change and I have incremented the API version and added a summary to CHANGELOG.md.

@ghost ghost requested a review from ialarmedalien as a code owner February 24, 2022 00:38
* Taxonomy taxonomy_search_species_strain_no_sort

The latter two are switched between depending on the length of the search text.
These stored query tests are all bundled in one test file because their original purpose is to do a species/strain
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double space between tests and are

@@ -1,3 +1,5 @@
# DEPRECATED. See taxonomy_search_species_strains and taxonomy_search_species_strains_no_sort
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know if anyone / anything is actually using this?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't think so

Copy link
Copy Markdown
Collaborator

@ialarmedalien ialarmedalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 8b4457e into develop Feb 25, 2022
@ghost ghost deleted the DATAUP-701-query-testing branch February 25, 2022 00:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant