prep release and DATAUP-706-doc-startup#101
Merged
1 commit merged intodevelopfrom Mar 3, 2022
Merged
Conversation
ghost
requested a review
from 
| * Wait for response from auth, workspace, and arangodb services, as they are set up | ||
| * Specs are set up. Either the repo specs or remote specs are loaded into the specs root path | ||
| * Collections, views, and analyzers from the specs are added to the ArangoDB server. If the collection, view, or analyzer already exists, but in a different configuration, it will _not_ be overwritten. | ||
| * Collections, views, and analyzers from the loaded specs are compared to those on the ArangoDB server. If the loaded specs' attributes are not recursively a subset of the server specs, then an exception is raise. (This is just preliminary validation behavior.) |
Collaborator
There was a problem hiding this comment.
an exception is raised
I'd incorporate the last sentence into the previous two, so you have something like:
Basic validation of the collections, views, and analyzers is performed by comparing the loaded specs to those on the ArangoDB server. If the loaded specs' attributes are not recursively a subset of the server specs, an exception is raised and ... (server start up fails? what happens if there's an exception?)
Author
There was a problem hiding this comment.
Ok ... that sounds good ... but I'm gonna call perfect is the opposite of good
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For changes to the codebase: