Skip to content

Long query testing -- violin plots comparing old and new query performance#102

Merged
3 commits merged intodevelopfrom
DATAUP-733-compare-graph-exe-time-stats
Mar 21, 2022
Merged

Long query testing -- violin plots comparing old and new query performance#102
3 commits merged intodevelopfrom
DATAUP-733-compare-graph-exe-time-stats

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 17, 2022

  • I updated the README.md docs to reflect this change.

For changes to the codebase:

  • I have written tests to cover this change.
  • This is not a breaking API change OR
  • This is a breaking API change and I have incremented the API version and added a summary to CHANGELOG.md.

Not sure if this belongs in the main repo. It's just refactoring of the long query tests and then adding graphing of results.

@ghost ghost requested a review from ialarmedalien as a code owner March 17, 2022 21:31
@ghost ghost changed the title Dataup 733 compare graph exe time stats Long query testing -- violin plots comparing old and new query performance Mar 17, 2022
"""Determine whether to use the sorting or non-sorting query"""
"""
Determine whether to use the sorting or non-sorting stored query for the new query.
Smaller search texts' results will not be sorted on.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a handy VSCode extension that I've been using to do this - "autoDocstring: VSCode Python Docstring Generator"

Copy link
Copy Markdown
Collaborator

@ialarmedalien ialarmedalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 51078b0 into develop Mar 21, 2022
@ghost ghost deleted the DATAUP-733-compare-graph-exe-time-stats branch March 21, 2022 20:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant