DATAUP-748 use locale en_US & other cleanup#114
Conversation
| import os | ||
| from uuid import uuid4 | ||
|
|
||
| from relation_engine_client import REClient |
There was a problem hiding this comment.
This was confusing since relation_engine_client is a directory with an __init__.py that defined __all__ with main.REClient
| @unittest.skip( | ||
| "Insofar inexplicable requests.exceptions.ConnectionError. " | ||
| "Failure mode for empty query not imperative" | ||
| ) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| if scheme in self.handlers: | ||
| result = self.handlers[scheme](uri) | ||
| elif scheme in [u"http", u"https"]: | ||
| elif scheme in ["http", "https"]: |
| @@ -1,94 +0,0 @@ | |||
| # Should be REVISED or DEPRECATED. | |||
There was a problem hiding this comment.
I wrote this and I know it's not being used because of performance issues so axed the cruft
| ) | ||
|
|
||
|
|
||
| class TestFulltextSearchStoredQuery(unittest.TestCase): |
There was a problem hiding this comment.
Removed tests pertaining to now axed spec/stored_queries/generic/fulltext_search.yaml
ghost
marked this pull request as ready for review
ialarmedalien
left a comment
ialarmedalien
left a comment
There was a problem hiding this comment.
Can you do a little more investigation into the admin query failure? Better still, remove that change from this PR (the rest is fine) and then do some investigation in another PR.
ghost
force-pushed
the
DATAUP-748-test-locale
branch
from
2da9bd5 to
dee3ce3
Compare
ghost
force-pushed
the
DATAUP-748-test-locale
branch
from
dee3ce3 to
bc5c32d
Compare
| docker-compose* | ||
|
|
||
| # Temp files | ||
| tmp/ |
There was a problem hiding this comment.
These are generated by the comprehensive query testing, or any output files can go here
|
|
||
| reset: | ||
| docker-compose --rmi all -v | ||
| docker-compose build |
There was a problem hiding this comment.
Forgot "down", and the "build" is redundant since the other make targets do it
|
Yep, was planning on that |
1 participant
Change the locale of the
ci::icu_tokenizeanalyzer toen_USand do some comprehensive-ish tests (a subset of the 10-day tests) to ensure that the index and AQL tokenizer still agree on word boundaries and such.Also removed the generic/fulltext_search.yaml which I wrote so I know it's not used anywhere because it has performance issues.
For changes to the codebase: