Add SPEC_TEST_READY env var#23
Merged
jayrbolton merged 2 commits intodevelopfrom Aug 28, 2020
Merged
Conversation
…ar is not present and the tests require the full specs, they will be loaded.
jayrbolton
reviewed
Aug 28, 2020
| with modified_environ(RES_ROOT_DATA_PATH=os.path.join(_TEST_DIR, 'djornl', 'test_data')): | ||
| parser = DJORNL_Parser() | ||
| parser.load_data() | ||
| self.assertEqual(True, parser.load_data()) |
Contributor
There was a problem hiding this comment.
This can be assertTrue(parser.load_data())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an environment variable that indicates when specs from the
/app/specdirectory (i.e. whatever is inspecwhen the docker image is created) have been loaded into ArangoDB. This ensures that all the tests inspec/,relation_engine_server/, andimporters/can be run without needing to be in any special order. The tests inclient_srcare (still) a special case as they need a certainPYTHONPATHenv var to be set.