Skip to content

query testing & split for sorting#99

Merged
3 commits merged intodevelopfrom
DATAUP-701-query-testing
Feb 22, 2022
Merged

query testing & split for sorting#99
3 commits merged intodevelopfrom
DATAUP-701-query-testing

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 18, 2022

  • I updated the README.md docs to reflect this change.

For changes to the codebase:

  • I have written tests to cover this change.
  • This is not a breaking API change OR
  • This is a breaking API change and I have incremented the API version and added a summary to CHANGELOG.md.

@ghost ghost requested a review from ialarmedalien as a code owner February 18, 2022 01:32
@ghost ghost force-pushed the DATAUP-701-query-testing branch from e128f18 to d6a1bed Compare February 18, 2022 01:45
Comment thread .gitignore
Comment thread scripts/run_tests.sh Outdated
Comment thread spec/stored_queries/taxonomy/taxonomy_ncbi_species.yaml
Comment thread spec/stored_queries/taxonomy/taxonomy_ncbi_species_no_sort.yaml
@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 18, 2022

IDK if I should add my Google docs "ADR" as a pdf somewhere under an adr directory

Comment thread dev-requirements.txt
Comment thread spec/test/stored_queries/test_query.py
Comment thread spec/test/stored_queries/test_query.py
Comment thread spec/test/stored_queries/test_query.py
Comment thread spec/test/stored_queries/test_query.py Outdated
Copy link
Copy Markdown
Collaborator

@ialarmedalien ialarmedalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and one minor change to use your jprint function.

@ialarmedalien
Copy link
Copy Markdown
Collaborator

RE: ADR: add it as plain text and put it into a separate PR since this one is almost ready to go.

@ghost ghost merged commit 770e6c0 into develop Feb 22, 2022
@ghost ghost deleted the DATAUP-701-query-testing branch February 22, 2022 19:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant