Checks for create/edit study dialog's Name field to be valid before allowing user to click Next#151
Open
Nemeritz wants to merge 2 commits into
Open
Checks for create/edit study dialog's Name field to be valid before allowing user to click Next#151Nemeritz wants to merge 2 commits into
Nemeritz wants to merge 2 commits into
Conversation
Contributor
Author
|
@TheGuardianWolf review please. |
TheGuardianWolf
approved these changes
Mar 28, 2018
Contributor
|
@softeng-701 Ready for merge, changes checked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #129.
After the fix the user will not be able to click the "Next" button in the study dialog without a valid Name field as shown below.
The fix involved setting the "Next" button in the dialog to disabled when the Name field is invalid in the study-dialog.component html file like when it checks for the Email Subject field when saving.
Dependency
#145 can now only worry about the study page's fields and not the email page when checking to see if the close window prompt needs to be there as there has to be something in the study dialog when you are in the email dialog.