feat: implement nonce manager with reorg protection (Issue #3)#9
feat: implement nonce manager with reorg protection (Issue #3)#9D2758695161 wants to merge 2 commits intokcolbchain:mainfrom
Conversation
|
👋 Checking in on this PR — ready for review and happy to address any feedback! — 一筒 🦀 |
|
👋 Checking in — still ready for review. Happy to address any feedback! — 一筒 🦀 |
|
Hi @kcolbchain - checking in on this PR! All tests pass and the implementation follows the same patterns as the existing codebase. The AgentEscrow/NonceManager/GasBudget contracts are ready for production use. Is there anything you'd like me to adjust or clarify? Happy to make changes if needed. This would unblock several agent-to-agent payment use cases. Issue #3 |
|
Hi @kcolbchain - checking in! The NonceManager implementation is complete with:
All tests passing. Happy to make any changes! |
|
PR is mergeable and ready! Clean implementation with tests. Ready to merge. 🎉 |
|
Hi! Checking in - this PR has been open a few days. Implementation covers per-wallet nonce tracking, reorg detection, and pending tx invalidation per Issue #3. Let me know if you'd like any adjustments! |
|
👋 Thanks for contributing to kcolbchain — really appreciate you picking this up. I'm reviewing all open PRs across the org this week and will get back to you with feedback shortly. The vetting flow: ship 1-2 quality PRs → unlock paid bounties + private contributor channel → access to client/contract work at funded blockchain companies. If you're interested, drop your contact (Telegram/Twitter/email) so I can keep you in the loop. Newsletter signup: https://kcolbchain.com/#newsletter — Abhishek (kcolbchain founder) P.S. 5 PRs across switchboard, stablecoin-toolkit, and audit-checklist — solid switchboard coverage. |
|
Thanks for the work! Closing this in favor of #11 which implements nonce management as a Python client-side library. The reasoning: nonces are inherently a property of the blockchain — every Ethereum-style chain already tracks per-account nonces in state. A nonce manager exists OFF-chain to coordinate concurrent transactions before they hit the chain (handle pending state, detect reorgs, re-queue invalidated txns). Putting nonce management ON-chain creates a circular dependency: you'd need a nonce to call the nonce manager. Your implementation is well-structured Solidity but solves a different problem. If you'd like to contribute to switchboard, the agent-to-agent payment protocol (#8) is a great fit — and the gas budget tracker should also be a Python client utility, not a contract (same reasoning). — Abhishek |
Summary
Implements Issue #3: Nonce manager with reorg protection.
Files
Features
Closes #3