Skip to content

Ignore cluster in ctx for non-aware caches, and error for the inverse#49

Merged
kcp-ci-bot merged 2 commits intokcp-dev:kcp-0.17from
sttts:sttts-check-cluster-aware
Mar 11, 2024
Merged

Ignore cluster in ctx for non-aware caches, and error for the inverse#49
kcp-ci-bot merged 2 commits intokcp-dev:kcp-0.17from
sttts:sttts-check-cluster-aware

Conversation

@sttts
Copy link
Copy Markdown
Member

@sttts sttts commented Mar 9, 2024

A cluster-aware cache has cluster indexes. Use that to error if a cluster is missing in the context. Inverse, ignore the cluster for a cluster-unaware cache, e.g. one against a normal kube cluster.

Signed-off-by: Dr. Stefan Schimanski stefan.schimanski@gmail.com

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 9, 2024
@sttts sttts force-pushed the sttts-check-cluster-aware branch from 57d9cb3 to 6241fd9 Compare March 9, 2024 18:20
@sttts
UPSTREAM: <squash>: ignore cluster in ctx for non-aware caches, and e…
6a7c677 
…rror for the inverse

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts sttts force-pushed the sttts-check-cluster-aware branch from 6241fd9 to 6a7c677 Compare March 9, 2024 21:17
@kcp-ci-bot kcp-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 9, 2024
@sttts
Copy link
Copy Markdown
Member Author

sttts commented Mar 9, 2024

/assign @embik

@sttts
Address comments
34979e8 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
embik
embik approved these changes Mar 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2024
@kcp-ci-bot
Copy link
Copy Markdown

kcp-ci-bot commented Mar 10, 2024

LGTM label has been added.

DetailsGit tree hash: a59ac113c8757529eee895c232399abc170f61b3

@kcp-ci-bot
Copy link
Copy Markdown

kcp-ci-bot commented Mar 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2024
@embik
Copy link
Copy Markdown
Member

embik commented Mar 10, 2024

/hold

for additional reviews :)

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2024
@embik
Copy link
Copy Markdown
Member

embik commented Mar 10, 2024

/cc @yastij

@kcp-ci-bot
Copy link
Copy Markdown

kcp-ci-bot commented Mar 10, 2024

@embik: GitHub didn't allow me to request PR reviews from the following users: yastij.

Note that only kcp-dev members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @yastij

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yastij
Copy link
Copy Markdown

yastij commented Mar 11, 2024

/lgtm

@kcp-ci-bot
Copy link
Copy Markdown

kcp-ci-bot commented Mar 11, 2024

@yastij: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Copy Markdown
Member Author

sttts commented Mar 11, 2024

/hold cancel

@kcp-ci-bot kcp-ci-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@kcp-ci-bot kcp-ci-bot merged commit a29f17f into kcp-dev:kcp-0.17 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sttts @kcp-ci-bot @embik @yastij