Fixed opening file: URIs without authority on macOS#123
Merged
kdroidFilter merged 1 commit intokdroidFilter:masterfrom Oct 10, 2025
Merged
Fixed opening file: URIs without authority on macOS#123kdroidFilter merged 1 commit intokdroidFilter:masterfrom
file: URIs without authority on macOS#123kdroidFilter merged 1 commit intokdroidFilter:masterfrom
Conversation
This patch addresses an important case when the URI has the form of `file:/Users/.../file.mp4` where authority (//) is not provided. This problem specifically shows up when opening files from Compose Multiplatform resources, acquired by `Res.getUri()` method, which in turn calls java's `ClassLoader.getResource()` method that returns a URI without authority.
Owner
|
Looks great ! |
Contributor
Author
|
@kdroidFilter thanks for your quick feedback :) It appears that the Windows build has failed due to an unrelated issue with WASM. Is it a known issue? Unfortunately, I don't have a Windows machine at hand, so I'm unable to check it myself. |
Owner
|
Yes it's a know issue. Thanks a lot !! |
Contributor
Author
|
Awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses an important case when the URI has the form of
file:/Users/.../file.mp4where authority (//) is not provided. This problem specifically shows up when opening files from Compose Multiplatform resources, acquired byRes.getUri()method, which in turn calls java'sClassLoader.getResource()method that returns a URI without authority.