Video player state interface#147
Merged
kdroidFilter merged 3 commits intokdroidFilter:masterfrom Dec 24, 2025
Merged
Conversation
5c7b91e to
ff4da79
Compare
Contributor
Author
7cfab0e to
b3a1c8f
Compare
Owner
|
Thank you so much, I really like it, it’s super convenient! |
Contributor
Author
|
I will try, but I won't be able to test on Mac, Windows, iOS, I only have a Linux laptop |
b3a1c8f to
b8fcdaf
Compare
Contributor
Author
|
Hi, I solved all the conflicts and tested on
For other platform Win, Mac, iOS, I think that it compiles, but I don't have MAC or iPhone to test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Allow consumer to mock the VideoPlayer in all kind of situations (for Previewing or testing). For example
Solution
Turn VideoPlayerState to interface, consumer provides their own (mock) Player State for previewing (or testing).
Breaking changes
VideoPlayerState()becomescreateVideoPlayerState()Note: this breaking change won't impact most consumers, because they usually use
rememberVideoPlayerState()to instantiate a newVideoPlayerState