fix: loop no smooth on Ios player#164
Conversation
|
@marioortizmanero check this |
|
Thank you very much, I think this should fix the issue. Could you provide a screen recording showing before and after the change? |
fix-126-issue-demo.mov |
|
sorry, can you check with a sample like this https://pixabay.com/videos/neon-terrain-80-retro-abstract-21368/ ? (download it) |
|
PR #164 looks good, and the zero-tolerance seek with playback resumed after completion makes sense for avoiding loop stutter on iOS. |
Screen.Recording.2026-02-02.at.10.06.26.PM.mov |
|
Great ! Thanks a lot ! |
|
Thank you guys for the help! I will test it early next week and send a confirmation. In the meanwhile feel free to share your paypal details for the bounty |
|
Thanks Mario! 🙌 @marioortizmanero If you need any additional testing, verification on iOS, or follow-up fixes after your testing next week, I’m happy to help. |
|
@marioortizmanero can u send the money to my friend dhia by the end of the month additional to his pay, he will give it to me in person, our country dosent support paypal |
|
@YoussefHachicha just send me the email address and I'll be happy to send the money there |
|
Hey sorry for being so late in the end. I'm running the side-by-side comparison but I think this isn't fixed for me yet? I've tried on an iPhone SE. Here's the before and after, and the original video: Before this patch: ScreenRecording_02-22-2026.17-23-46_1.MP4After this patch: ScreenRecording_02-22-2026.17-32-55_1.MP4Here's the original video: JUMPING_JACKS.mp4And here's the original video playing multiple times in a row to show the expected smoothness (just copy-pasted the track 4 times on CapCut): 0222.mp4My code is just: |
|
Also @kdroidFilter I think 0.8.8 is missing on Maven, I just did these tests locally |
Summary
Changes
seekToTimewith zero tolerance (toleranceBeforeandtoleranceAfter) for precise seekingplayImmediatelyAtRateTest plan
Fixes #126