Skip to content

Fix macOS isMenuBarInDarkMode returning true in light mode #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdroidFilter merged 1 commit into from
Feb 3, 2026
Merged

Fix macOS isMenuBarInDarkMode returning true in light mode #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions maclib/tray.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,10 +303,18 @@ public func tray_set_theme_callback(_ cb: @escaping ThemeCallback) {

@_cdecl("tray_is_menu_dark")
public func tray_is_menu_dark() -> Int32 {
if !Thread.isMainThread {
return DispatchQueue.main.sync { tray_is_menu_dark() }
}
let ctx = trayInstance.flatMap { contexts[$0] } ?? contexts.values.first
guard let button = ctx?.statusItem.button else { return 1 }
guard let name = button.effectiveAppearance.bestMatch(from: [NSAppearance.Name.darkAqua, NSAppearance.Name.aqua]) else {
return 1 // assume dark if unknown
let appearance: NSAppearance
if let button = ctx?.statusItem.button {
appearance = button.effectiveAppearance
} else {
appearance = NSApp.effectiveAppearance
}
guard let name = appearance.bestMatch(from: [.darkAqua, .aqua]) else {
return 1
}
return name == .darkAqua ? 1 : 0
}
Expand Down
Loading