Guard tray_enable_dark_mode with SEH to prevent crash on Windows 10#2
Merged
kdroidFilter merged 2 commits intomasterfrom Feb 3, 2026
Merged
Guard tray_enable_dark_mode with SEH to prevent crash on Windows 10#2kdroidFilter merged 2 commits intomasterfrom
kdroidFilter merged 2 commits intomasterfrom
Conversation
Zero-initialize NOTIFYICONIDENTIFIER in tray_windows.c to prevent undefined behavior, ensuring compatibility with Windows APIs. Refactored WindowsTrayManager to improve safety, including null pointer checks, better error handling for memory access issues, and extraction of reusable `safeGetTrayPosition` logic. Updated binaries to reflect these critical fixes.
The undocumented ordinal 135 of uxtheme.dll (SetPreferredAppMode) can cause an access violation on some Windows 10 builds. Wrap the call in __try/__except so the crash is silently caught — dark-mode theming is cosmetic only and safe to skip. Fixes kdroidFilter/ComposeNativeTray#350
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tray_enable_dark_mode()in__try/__except(SEH) insidetray_init()uxtheme.dll(SetPreferredAppMode) can cause an access violation on some Windows 10 buildsFixes kdroidFilter/ComposeNativeTray#350