Fix zh-TW typo in banner.js

[ray2c]

The external banner looks great and sounds like a good idea! I just spotted a typo in the zh-TW copy and fix the same in this MR.

Tangentially, one curious question about the UX which perhaps I'll throw out as food for thought: (which actually applies to the banner on f-droid.org as well)

• From a UI perspective, once the user dismisses the banner, there's no easy way to re-enable the banner (short of clearing site data).

It's a relatively minor issue in itself, but human experience tells us that this could happen, say, when users dismiss banners out of 'muscle memory' (thanks to proliferation of ads) and indeed, human users need constant reminders (which the banner is exactly for) and they tend to change their minds and perhaps would like to re-read the banner again at a later time.

Indeed, if one looks at other designs out there (such as ads — not a great example though), they rarely really dismiss the banner entirely with its 'close' button or persist the dismissal perpetually as a preference, but rather 'minimize' it so that it becomes visually less intrusive (eg to a slim 'expand' button that sits silently to one side of the screen).

One idea I think of might be that, instead of dismissing the banner in its entirety when the user clicks on the 'x' button, perhaps we may 'minimize' it to, say, a 'faded' (semi-transparent) icon (such as the website icon at the bottom of the page) that sits non-prominently at a corner, so that the users can 're-activate' the banner again when they click on the dimmed icon. (The dimmed icon may also serve as a constant reminder in a non-obtrusive way.)

Anyway, just an idea as food for thought which we may pick up at a later time.

Thanks once again for the great work all the way!

[marcprux]

Thanks for the language fix!

From a UI perspective, once the user dismisses the banner, there's no easy way to re-enable the banner (short of clearing site data).

The current behavior is to hide it for 30 days, and then it will show up again (at which point they can dismiss it again).

I don't want to be too aggressive about forcing some vestige of it to remain on the screen, since if they user decided they don't want to see it, we should respect that (at least for 30 days).

[ray2c]

The current behavior is to hide it for 30 days, and then it will show up again (at which point they can dismiss it again).

Yeah, make sense to me. Thanks for your reply!