fix(test): use all IPv4 interfaces in test_disable_interface_cache#435
Open
keepsimple1 wants to merge 2 commits intomainfrom
Open
fix(test): use all IPv4 interfaces in test_disable_interface_cache#435keepsimple1 wants to merge 2 commits intomainfrom
keepsimple1 wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix issue #432 .
Problem
In
test_disable_interface_cache, we only disable the first IPv4 address returned. On a host with multiple IPv4 addresses, it is possible that the service record is received again via another IPv4 address (loopback enabled or even on the same subnet) and hence resolve the service instance again.Changes
Disable all IPv4 addresses on the host except the localhost loopback address, hence remove the cache on all IPv4 interfaces.