Skip to content

Conversation

@cappuc
Copy link
Contributor

@cappuc cappuc commented Nov 20, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 20, 2025 16:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR unifies the Docker image build process by consolidating multiple Dockerfiles into a single parameterized base.Dockerfile and upgrades to serversideup/php 4.0. Key changes include renaming the OS_VARIANT parameter to OS, introducing a VARIANT parameter to support both fpm-nginx and frankenphp builds, and updating dependencies (supercronic to v0.2.39, Node.js to v24).

  • Consolidated separate php-fpm.Dockerfile and php-frankenphp.Dockerfile into a unified base.Dockerfile with build arguments
  • Updated from serversideup 3.6.1 to 4.0.0 with renamed variables (OS_VARIANTOS)
  • Refactored GitHub Actions workflow to use a matrix strategy for building multiple PHP versions, OS variants, and server variants

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
php/php-fpm.Dockerfile Deleted - functionality consolidated into base.Dockerfile
php/base.Dockerfile Unified Dockerfile with OS and VARIANT parameters; updated to serversideup 4.0 and supercronic v0.2.39
php/common/usr/local/etc/php/conf.d/xxx-keepsuit-php.ini Removed opcache configuration (now managed via environment variables in Dockerfile)
php/common/usr/local/bin/docker-php-serversideup-setup Updated variable reference from OS_VARIANT to OS
php/common/usr/local/bin/docker-php-serversideup-install-puppeteer Updated Node.js version from 22 to 24
php/common/etc/entrypoint.d/51-laravel-packages-automations.sh Deleted - Laravel package automations removed
php/common/etc/entrypoint.d/10-init-scheduler.sh Added -quiet -passthrough-logs flags to supercronic for cleaner logging
.github/workflows/build.yml Refactored to use matrix strategy with combinations of PHP versions, OS types, and variants; added dev branch builds with dev tag prefix
Comments suppressed due to low confidence (1)

php/base.Dockerfile:47

  • The VARIANT ARG is used here but is not re-declared after the FROM statement. ARG variables declared before FROM are not available in subsequent build stages. You need to add ARG VARIANT after line 50 (alongside the other ARG re-declarations) to make this variable available for the conditional check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cappuc and others added 2 commits November 20, 2025 17:35
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@cappuc cappuc merged commit 87409a9 into master Nov 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants