Skip to content

Fix whitespace trim not working on {%- endcomment -%} tag. #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cappuc merged 4 commits into from
Dec 1, 2025
Merged

Fix whitespace trim not working on {%- endcomment -%} tag. #53

cappuc merged 4 commits into from
Dec 1, 2025

Conversation

@ryo-morimoto
Copy link
Contributor

@ryo-morimoto ryo-morimoto commented Nov 30, 2025 •
edited
Loading

  • Modified blockCommentDataRegex() to capture the closing tag with whitespace trim marker
  • Added trimWhitespaces() call in lexComment() when -%} is detected
  • Added unit and integration tests for comment tag whitespace trim

Fixes #52

@ryo-morimoto ryo-morimoto changed the title add comment tag whitespace trim tests Fix whitespace trim not working on {%- endcomment -%} tag. Nov 30, 2025
@cappuc
Copy link
Contributor

cappuc commented Dec 1, 2025

Thank you!

It looks good to me!

@cappuc cappuc merged commit 1f35dbf into keepsuit:main Dec 1, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Whitespace trim on {%- endcomment -%} tag does not remove trailing whitespace

2 participants

@ryo-morimoto @cappuc