Skip to content

fix: re-add runOnce property to CronJob#751

Merged
sheerlox merged 1 commit intokelektiv:mainfrom
sheerlox:fix/add-runOnce-property-back
Oct 26, 2023
Merged

fix: re-add runOnce property to CronJob#751
sheerlox merged 1 commit intokelektiv:mainfrom
sheerlox:fix/add-runOnce-property-back

Conversation

@sheerlox
Copy link
Copy Markdown
Collaborator

Description

add runOnce back to CronJob, this time as a getter to shadowing this.cronTime.realDate value.

Related Issue

#740 (comment)

Motivation and Context

removing this property was a breaking change.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change introduces a breaking change, I have added a ! after the type/scope in the title (see the Conventional Commits standard).

@sheerlox sheerlox added the type:bug Bug reports and bug fixes label Oct 25, 2023
@sheerlox sheerlox requested a review from intcreator October 25, 2023 21:20
@sheerlox sheerlox merged commit a61d8c9 into kelektiv:main Oct 26, 2023
@sheerlox sheerlox deleted the fix/add-runOnce-property-back branch October 26, 2023 18:31
ncb000gt pushed a commit that referenced this pull request Oct 26, 2023
## [3.1.5](v3.1.4...v3.1.5) (2023-10-26)

### 🐛 Bug Fixes

* detect multiple zeros as an invalid step ([#743](#743)) [skip ci] ([b0bf677](b0bf677))
* re-add runOnce property to CronJob ([#751](#751)) ([a61d8c9](a61d8c9))

### 📚 Documentation

* **readme:** API documentation overhaul ([#716](#716)) [skip ci] ([23fb0a3](23fb0a3))

### ⚙️ Continuous Integrations

* **action:** update actions/setup-node action to v4 ([#749](#749)) ([ef850f3](ef850f3))

### ♻️ Chores

* **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v18 ([#747](#747)) ([5ff1cf8](5ff1cf8))
* **deps:** update dependency sinon to v17 ([#748](#748)) ([9d61ff9](9d61ff9))
* **deps:** update linters ([7bdc726](7bdc726))
* improve ossf scorecard's score ([#715](#715)) [skip ci] ([1284df4](1284df4))
@ncb000gt
Copy link
Copy Markdown
Member

🎉 This PR is included in version 3.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

sheerlox added a commit to sheerlox/node-cron that referenced this pull request Oct 29, 2023
sheerlox added a commit to sheerlox/node-cron that referenced this pull request Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released type:bug Bug reports and bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants