ci: add pre-commit hook to lint and prettify#911
Merged
intcreator merged 4 commits intomainfrom Nov 12, 2024
Merged
Conversation
intcreator
force-pushed
the
intcreator/prettier-pre-commit
branch
from
7ba20a6 to
969d616
Compare
intcreator
force-pushed
the
intcreator/prettier-pre-commit
branch
from
969d616 to
d8b8262
Compare
sheerlox
approved these changes
Nov 12, 2024
Member
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
JosephVoid
pushed a commit
to JosephVoid/node-cron
that referenced
this pull request
Dec 14, 2024
## [3.3.0](kelektiv/node-cron@v3.2.1...v3.3.0) (2024-12-10) ### ✨ Features * support async handling and add CronJob status tracking ([kelektiv#894](kelektiv#894)) ([b58fb6b](kelektiv@b58fb6b)), closes [kelektiv#713](kelektiv#713) [kelektiv#556](kelektiv#556) ### ⚙️ Continuous Integrations * **action:** update github/codeql-action action to v3.27.2 ([kelektiv#912](kelektiv#912)) ([d11ba30](kelektiv@d11ba30)) * **action:** update github/codeql-action action to v3.27.5 ([kelektiv#917](kelektiv#917)) ([2a4035e](kelektiv@2a4035e)) * **action:** update step-security/harden-runner action to v2.10.2 ([kelektiv#920](kelektiv#920)) ([26a8f9f](kelektiv@26a8f9f)) * add pre-commit hook to lint and prettify ([kelektiv#911](kelektiv#911)) ([e1140d1](kelektiv@e1140d1)), closes [kelektiv#907](kelektiv#907) ### ♻️ Chores * **deps:** lock file maintenance ([94465ae](kelektiv@94465ae)) * **deps:** lock file maintenance ([23d67a4](kelektiv@23d67a4)) * **deps:** lock file maintenance ([135fdf7](kelektiv@135fdf7)) * **deps:** lock file maintenance ([edcff3b](kelektiv@edcff3b)) * **deps:** pin dependency lint-staged to 15.2.10 ([kelektiv#916](kelektiv#916)) ([5cf24da](kelektiv@5cf24da)) * **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v19.6.0 ([9d9ab94](kelektiv@9d9ab94)) * **deps:** update dependency [@types](https://github.com/types)/node to v20.17.7 ([9181b6a](kelektiv@9181b6a)) * **deps:** update dependency [@types](https://github.com/types)/node to v20.17.8 ([5899fc2](kelektiv@5899fc2)) * **deps:** update dependency [@types](https://github.com/types)/node to v20.17.9 ([ca5065a](kelektiv@ca5065a)) * **deps:** update dependency husky to v9.1.7 ([a960a29](kelektiv@a960a29)) * **deps:** update dependency typescript to v5.7.2 ([3447ff5](kelektiv@3447ff5))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add a pre-commit hook to run eslint on .ts files and prettify on JSON, MD, and YML files
Related Issue
fixes #907
Motivation and Context
a lot of times contributors make a PR just for it to fail because of linting/prettification requirements and have to manually run the linters locally and push a new commit with the fix. this change will lint/prettify on commit automatically, removing friction to contribution
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).