Reworking how ingest_spectrum works using the ORM#4
Closed
dr-rodriguez wants to merge 3 commits intokelle:pyspextool-ingestfrom
Closed
Reworking how ingest_spectrum works using the ORM#4dr-rodriguez wants to merge 3 commits intokelle:pyspextool-ingestfrom
dr-rodriguez wants to merge 3 commits intokelle:pyspextool-ingestfrom
Conversation
Author
|
Could also set it to merge into SIMPLE-AstroDB:main but if you wanted to use this for your branch first, this may be one way to do it. As a note, this does pass our tests but the automated pipeline will likely only run if merging against SIMPLE-AstroDB. |
Owner
|
Love this! I was working on it last night and ended up almost in the same place for catching missing values (eg, regime is required). :) Question: how do we validate |
* Create requirements.txt file * Removing old files and updating documentation * Updating tests to use requirements.txt * add explicit python vs command line * fix numbering. --------- Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
Author
|
Withdrawn in favor of SIMPLE-AstroDB#501 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is attempting to rework how
ingest_spectrumfunctions by utilizing the ORM and removing extra checks.Some of the tests were failing since there are explicit strings that were being checked- they "bad" examples still fail, they just do so for other reasons or the string output is different. Some test cleanup may be needed.
We may also want to consider expanding the cleanup and/or revisit the use of
flags