Open
Conversation
The previous approach suffers from provider instances losing their relation to the actual source class. This is caused by abstract base class methods that reduce instances to their base type in unexpected ways. This leads to type assumptions that ultimately don't hold up during runtime, and cause hard-to-analyze issues. This change moves abstract methodology into the concrete types, composing merged types, and then using those composed types instead of base class references. While this change generally seems to perform as expected and correctly (1 test is failing locally), it should likely be cleaned up to integrate better with the rest of the code structure and style. The change is primarily motivated to help illustrate the solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous approach suffers from provider instances losing their relation to the actual source class. This is caused by abstract base class methods that reduce instances to their base type in unexpected ways. This leads to type assumptions that ultimately don't hold up during runtime, and cause hard-to-analyze issues.
This change moves abstract methodology into the concrete types, composing merged types, and then using those composed types instead of base class references.
While this change generally seems to perform as expected and correctly (1 test is failing locally), it should likely be cleaned up to integrate better with the rest of the code structure and style. The change is primarily motivated to help illustrate the solution.