Closed
Conversation
github-actions
Bot
added
documentation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
==========================================
- Coverage 61.67% 57.98% -3.70%
==========================================
Files 137 102 -35
Lines 10473 8701 -1772
==========================================
- Hits 6459 5045 -1414
+ Misses 3763 3475 -288
+ Partials 251 181 -70
... and 55 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
RealAnna
force-pushed
the
poc/scheduling_gates
branch
from
64f139a to
197947f
Compare
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
RealAnna
force-pushed
the
poc/scheduling_gates
branch
from
4385f3e to
c40413f
Compare
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com> fix operator import Signed-off-by: realanna <anna.reale@dynatrace.com> poc: fix lib import Signed-off-by: realanna <anna.reale@dynatrace.com> poc: fix lib import Signed-off-by: realanna <anna.reale@dynatrace.com> poc: fix lib import Signed-off-by: realanna <anna.reale@dynatrace.com> poc: tidy Signed-off-by: realanna <anna.reale@dynatrace.com> poc: tidy Signed-off-by: realanna <anna.reale@dynatrace.com> poc: tidy Signed-off-by: realanna <anna.reale@dynatrace.com> poc: tidy Signed-off-by: realanna <anna.reale@dynatrace.com> poc: rebased with controller runtime Signed-off-by: realanna <anna.reale@dynatrace.com> poc: up kind version Signed-off-by: realanna <anna.reale@dynatrace.com> poc: removed logger in favour of test logger Signed-off-by: realanna <anna.reale@dynatrace.com> poc: fixed otel Signed-off-by: realanna <anna.reale@dynatrace.com> poc: patched k8s version for sigs.k8s.io/controller-runtime Signed-off-by: realanna <anna.reale@dynatrace.com> poc: added gates Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna
force-pushed
the
poc/scheduling_gates
branch
from
aa9005e to
8d375c2
Compare
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
7 tasks
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. It will be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to tweak imports of controller runtime since the new version supporting k8s 1.27.1 is not yet released.
for the sake of poc the inner dependencies with klt-cert-manager has been replaced with pr ones for the sake of testing.
A few unit tests need to be fixed due to breaking changes in the library and there is a curious nil pointer issue with the decoder: the interface for injecting it has been removed from controller runtime, so we need to initiate it when creating the handlers kubernetes-sigs/controller-runtime#2134
But overall a separate webhook for gates seems to work.