Skip to content

ci: integrate python-runtime into pipelines#1505

Merged
odubajDT merged 3 commits intokeptn:mainfrom
odubajDT:feat/1491/python-runtime-pipelines
Jun 2, 2023
Merged

ci: integrate python-runtime into pipelines#1505
odubajDT merged 3 commits intokeptn:mainfrom
odubajDT:feat/1491/python-runtime-pipelines

Conversation

@odubajDT
Copy link
Copy Markdown
Contributor

@odubajDT odubajDT commented Jun 1, 2023

Fixes: #1491

Changes

  • changed python-runtime base image from python:3.9 to python:3.9-alpine to make the image size smaller
  • added python-runtime to all pipelines
  • added env variable pointing to the image into klt-operator Deployment
  • added helm value for setting up the image + updated the docs

Image available in ghrc: https://github.com/keptn/lifecycle-toolkit/pkgs/container/python-runtime

BEGIN_COMMIT_OVERRIDE
ci: integrate python-runtime into pipelines
END_COMMIT_OVERRIDE

@github-actions github-actions Bot added documentation Improvements or additions to documentation helm operator ops labels Jun 1, 2023
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 1, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit ae09125
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64786c45bff2930008265a06
😎 Deploy Preview https://deploy-preview-1505--keptn-lifecycle-toolkit.netlify.app/docs/crd-ref/lifecycle/v1alpha3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2023

Codecov Report

Merging #1505 (4cf3140) into main (672e281) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1505   +/-   ##
=======================================
  Coverage   62.66%   62.67%           
=======================================
  Files         140      140           
  Lines       10696    10696           
=======================================
+ Hits         6703     6704    +1     
+ Misses       3734     3733    -1     
  Partials      259      259           

see 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 57.95% <ø> (+0.60%) ⬆️
lifecycle-operator 84.18% <ø> (ø)
metrics-operator 81.66% <ø> (ø)
scheduler 30.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT changed the title feat(python-runtime): integrate python-runtime into pipelines feat: integrate python-runtime into pipelines Jun 1, 2023
odubajDT added 3 commits June 1, 2023 13:14
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

@odubajDT odubajDT marked this pull request as ready for review June 1, 2023 11:32
@odubajDT odubajDT requested a review from a team as a code owner June 1, 2023 11:32
@RealAnna RealAnna added the on hold Do not merge yet label Jun 1, 2023
@RealAnna
Copy link
Copy Markdown
Contributor

RealAnna commented Jun 1, 2023

let's wait the python runtime merge, since there are things that may change

Copy link
Copy Markdown
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pre-approving the PR but let's wait for the "on-hold" status to be solved by @RealAnna before the merge

@RealAnna RealAnna removed the on hold Do not merge yet label Jun 2, 2023
Copy link
Copy Markdown
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doublechecked with current changes of python runtime, we can merge 😸

@odubajDT odubajDT merged commit 069e049 into keptn:main Jun 2, 2023
@keptn-bot keptn-bot mentioned this pull request Jun 2, 2023
geoffrey1330 pushed a commit to geoffrey1330/lifecycle-toolkit that referenced this pull request Jun 2, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@thisthat thisthat changed the title feat: integrate python-runtime into pipelines ci: integrate python-runtime into pipelines Jun 20, 2023
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Jun 22, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation helm ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate Python runtime Runner image into pipelines

4 participants