feat: added support for controller runtime v0.15.0#1603
Closed
geoffrey1330 wants to merge 1 commit intokeptn:mainfrom
Closed
feat: added support for controller runtime v0.15.0#1603geoffrey1330 wants to merge 1 commit intokeptn:mainfrom
geoffrey1330 wants to merge 1 commit intokeptn:mainfrom
Conversation
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
geoffrey1330
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
RealAnna
reviewed
Jun 21, 2023
Contributor
There was a problem hiding this comment.
plz remove this is out of scope of the pr
RealAnna
reviewed
Jun 21, 2023
Contributor
There was a problem hiding this comment.
out of scope please remove
RealAnna
reviewed
Jun 21, 2023
Contributor
There was a problem hiding this comment.
as from other comments out of scope
RealAnna
reviewed
Jun 21, 2023
RealAnna
reviewed
Jun 21, 2023
RealAnna
reviewed
Jun 21, 2023
Comment on lines
+363
to
372
| "/gate-v1-pod": { | ||
| Handler: &gating.PodGatingWebhook{ | ||
| Client: mgr.GetClient(), | ||
| Tracer: otel.Tracer("keptn/gatewebhook"), | ||
| Decoder: decoder, | ||
| Recorder: mgr.GetEventRecorderFor("keptn/gatewebhook"), | ||
| Log: ctrl.Log.WithName("Gates Mutating Webhook"), | ||
| }, | ||
| }, | ||
| }); err != nil { |
Contributor
There was a problem hiding this comment.
this change is not needed in this pr
RealAnna
reviewed
Jun 21, 2023
Contributor
There was a problem hiding this comment.
remove changes to this file plz
RealAnna
reviewed
Jun 21, 2023
RealAnna
reviewed
Jun 21, 2023
RealAnna
reviewed
Jun 21, 2023
RealAnna
reviewed
Jun 21, 2023
Contributor
There was a problem hiding this comment.
this is out of scope, plz reove the file
RealAnna
reviewed
Jun 21, 2023
Contributor
There was a problem hiding this comment.
remove changes to this file plz
RealAnna
reviewed
Jun 21, 2023
| ) | ||
|
|
||
| replace golang.org/x/net => golang.org/x/net v0.10.0 | ||
| replace sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.15.0 No newline at end of file |
Contributor
There was a problem hiding this comment.
this line is not needed, please remove :)
Contributor
|
closed in favor of #1701 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: geoffrey1330 israelgeoffrey13@gmail.com
fixes #1457