Merged
Conversation
The repository with custom patches for github actions runner app has moved [1]. Update s390x.Dockerfile accordingly. [1] anup-kodlekere/gaplib#35 (comment) Signed-off-by: Ihor Solodrai <isolodrai@meta.com>
theihor
force-pushed
the
s390x-v2.324.0
branch
3 times, most recently
from
52cab7e to
2b0d012
Compare
Signed-off-by: Ihor Solodrai <isolodrai@meta.com>
For s390x we build native binaries of actions/runner app [1]. This is
a dotnet app with modifications from gaplib [2].
Recent release (v2.324.0) fails `./dev.sh test` command (which runs C#
tests) with the following error [3]:
[xUnit.net 00:01:19.89] GitHub.Runner.Common.Tests.Listener.RunnerL0.TestRunnerJobRequestMessageFromRunService_AuthMigrationFallback [FAIL]
Failed GitHub.Runner.Common.Tests.Listener.RunnerL0.TestRunnerJobRequestMessageFromRunService_AuthMigrationFallback [190 ms]
EXEC : error Message: [/opt/runner/src/dir.proj]
Moq.MockException :
Expected invocation on the mock exactly 2 times, but was 3 times: x => x.LoadCredentials(True)
After some debugging I came to a conclusion that this failure occurs
due to the slowness of qemu emulation. The test relies on timing of
particular events, which are too off in case of slow execution.
We could disable tests in our image build, given that many tests are
disabled by gaplib patches anyway. But that would increase the risk of
deploying a broken runner.
So instead I am adding a patch mitigating this specific test failure,
on top of gaplib to unblock s390x runner update.
[1] https://github.com/actions/runner/
[2] https://github.com/ppc64le/gaplib/
[3] https://github.com/kernel-patches/runner/actions/runs/15263732043/job/42925724125
Signed-off-by: Ihor Solodrai <isolodrai@meta.com>
Contributor
Author
|
Opened a PR for actions/runner: actions/runner#3877 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update s390x dockerfile to use newer gaplib and add a custom runner patch to mitigate a test failure.
See commits for details.