Skip to content

upd(novnc): remove old references #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgarcia merged 1 commit into from
Aug 25, 2025
Merged

upd(novnc): remove old references #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion images/chromium-headful/image-chromium/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
set -e

./start_all.sh
./novnc_startup.sh

python http_server.py > /tmp/server_logs.txt 2>&1 &

Expand Down
21 changes: 0 additions & 21 deletions images/chromium-headful/image-chromium/novnc_startup.sh
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions images/chromium-headful/run-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ RUN_ARGS=(
--mount type=bind,src="$FLAGS_FILE",dst=/chromium/flags,ro
)

# noVNC vs WebRTC port mapping
# WebRTC port mapping
Copy link

@cursor cursor bot Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: NoVNC Port Mapping Issue

Removing the else block for noVNC port mapping means that when ENABLE_WEBRTC is not set, port 8080 is no longer mapped. This makes the container inaccessible via localhost:8080, despite entrypoint.sh still instructing users to open that URL.

Fix in Cursor Fix in Web

if [[ "${ENABLE_WEBRTC:-}" == "true" ]]; then
echo "Running container with WebRTC"
RUN_ARGS+=( -p 8080:8080 )
Expand All @@ -55,9 +55,6 @@ if [[ "${ENABLE_WEBRTC:-}" == "true" ]]; then
RUN_ARGS+=( -e NEKO_WEBRTC_NAT1TO1=127.0.0.1 )
RUN_ARGS+=( -p 56000-56100:56000-56100/udp )
fi
else
echo "Running container with noVNC"
RUN_ARGS+=( -p 8080:6080 )
fi

docker rm -f "$NAME" 2>/dev/null || true
Expand Down
Loading