Benchmark tools [neko]

[raiden-staging]

• Benchmark tools added to API in kernel-images , relies on this new neko build
• WebRTC metrics originating from updated vue client in kernel-images are relayed by neko websockets to the benchmark API via logs

Next Steps :

• onkernel/neko
  • Merge PR (Benchmark tools [neko]) (this PR)
  • Release tag v3.0.8-v1.3.1 to trigger build
• onkernel/kernel-images
  • Merge PR (Benchmark tools [kernel-images]). Notes :
    • Dockerfile already set to ghcr.io/onkernel/neko/base:3.0.8-v1.3.1

[ @Sayan- @rgarcia ]

[mesa-dot-dev]

Mesa Description

• Benchmark tools added to API in kernel-images , relies on this new neko build
• WebRTC metrics originating from updated vue client in kernel-images are relayed by neko websockets to the benchmark API via logs

Next Steps :

• onkernel/neko
  • Merge PR (Benchmark tools [neko]) (this PR)
  • Release tag v3.0.8-v1.3.1 to trigger build
• onkernel/kernel-images
  • Merge PR (Benchmark tools [kernel-images]). Notes :
    • Dockerfile already set to ghcr.io/onkernel/neko/base:3.0.8-v1.3.1

[ @Sayan- @rgarcia ]

^{Description generated by Mesa. Update settings}

[mesa-dot-dev]

Performed full review of 5073274...47ee72c

Analysis

1. Security Vulnerability: The unauthenticated /internal/benchmark endpoint could enable DoS attacks, and benchmark stats file uses world-readable permissions (0644), potentially exposing sensitive system data.

2. Resource Leaks: Background goroutines lack cancellation mechanisms and run continuously without shutdown capability, leading to goroutine leaks and unnecessary resource consumption.

3. Performance Inefficiencies: Implementation uses O(n²) bubble sort instead of stdlib's O(n log n) sort for percentiles, and blocking 100ms sleep during CPU measurement may interfere with collection accuracy.

4. Data Corruption Risk: No atomic write pattern for benchmark files could lead to corrupted data during process crashes, and silent error handling in CPU stats parsing may produce incorrect metrics without indication.

5. Monitoring Gaps: Missing error logging when parsing /proc files fails, reducing observability and making troubleshooting difficult.

Tip

Help

Configure your agents

Mesa Docs

Slash Commands:

• /review - Request a full code review
• /review latest - Review only changes since the last review
• /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
• /help - Get help with Mesa commands and configuration options

^{15 files reviewed | 0 comments | Edit Agent Settings}