Refactor: correct issue extras response #1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tales-aparecida
requested changes
Aug 8, 2025
Altered the queries and objects in order to be clearer when an issue version doesn't exist or has no incidents Added the issue_version in the first incident object Fixed a problem where fetching for the extra details of more than one issue with the same id would only return one result for it Closes #1335
MarceloRobert
force-pushed
the
refactor/clear-issue-extras
branch
from
7be0f5b to
20fc8a2
Compare
tales-aparecida
approved these changes
Aug 8, 2025
giubrocchi
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
first_incidentfieldHow to test
Fetch some data from the issue_extras endpoint (I recommend using the localhost swagger ui) and test with issues that exist, that don't exist, that have 0 and more incidents, and other cases.
Also test the dashboard for the issue listing and issue details pages, everything should still be working as before.
Closes #1335